Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Kafka - Add missing record_count increment for JSON #18648

Merged
merged 9 commits into from
Nov 7, 2022
Merged

🐛 Source Kafka - Add missing record_count increment for JSON #18648

merged 9 commits into from
Nov 7, 2022

Conversation

alexnikitchuk
Copy link
Contributor

@alexnikitchuk alexnikitchuk commented Oct 29, 2022 •
edited
Loading

What

Kafka Source Connector with JSON format ignores max_records_process parameter due to the missing record_count increment

How

Add missing record_count increment

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Workaround for #14382

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 29, 2022
@vincentkoc vincentkoc changed the title add missing record_count increment 🐛 Source Kafka - Add missing record_count increment for JSON Nov 4, 2022
@vincentkoc
Copy link
Contributor

@alexnikitchuk thanks for your contribution, I’m one of the Airbyte maintainers and will be taking a look at your PR.

@vincentkoc
Copy link
Contributor

vincentkoc commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-kafka

🕑 connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/3393686268
✅ connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/3393686268
No Python unittests run

Build Passed

Test summary info:

All Passed

@vincentkoc vincentkoc self-assigned this Nov 4, 2022
@vincentkoc vincentkoc self-requested a review November 4, 2022 12:12
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 4, 2022
@vincentkoc
Copy link
Contributor

vincentkoc commented Nov 4, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kafka

🕑 Publishing the following connectors:
connectors/source-kafka
https://github.com/airbytehq/airbyte/actions/runs/3393798369


Connector Did it publish? Were definitions generated?
connectors/source-kafka ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@vincentkoc vincentkoc requested a review from a team November 4, 2022 12:35
@sajarin sajarin added the bounty-S Maintainer program: claimable small bounty PR label Nov 7, 2022
@sajarin sajarin merged commit 3365660 into airbytehq:master Nov 7, 2022
@alexnikitchuk alexnikitchuk deleted the add_missing_record_count_increment branch November 8, 2022 07:33
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentkoc vincentkoc vincentkoc approved these changes

Assignees

@vincentkoc vincentkoc

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty bounty-S Maintainer program: claimable small bounty PR community connectors/source/kafka
Projects
No open projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexnikitchuk @CLAassistant @vincentkoc @sajarin @octavia-squidington-iv @octavia-squidington-iii